end support of saving .ini file format for mirror configs#235
end support of saving .ini file format for mirror configs#235atsju merged 1 commit intogithubdoe:masterfrom
Conversation
gr5
left a comment
gr5
left a comment
There was a problem hiding this comment.
compiled and tested and it works. I looked at all the source code changes. That looks good as well.
|
Hi @githubdoe Again, no time pressure. Just shoot a little message to let me know what to expect. |
githubdoe
left a comment
githubdoe
left a comment
There was a problem hiding this comment.
Yes you can delete unused and the emit inside constructor I think.
This one is a false positive. I shall mute it. |
|
It seems to make sense to me that an emit in a constructor does not work since the connect will not be created till after the constructor is completed. So I'm not sure why you say false positive. Did you find that the emit actually worked? |
|
Yes it has been discussed before and I tested it at that time. #211 (comment) I can probably mute it or move the connect to a place where it will not warn but I can 100% confirm this one is a false positive. |
3 participants
close #233
I propose we do the v8.0.0-alpha1 after merging this.
To gather feedback if Qt6 brings any unexpected change/problem to users.